Skip to content

Version 5#50

Open
dtaylor-530 wants to merge 3 commits intojulianpaulozzi:masterfrom
dtaylor-530:Version_5
Open

Version 5#50
dtaylor-530 wants to merge 3 commits intojulianpaulozzi:masterfrom
dtaylor-530:Version_5

Conversation

@dtaylor-530
Copy link

Hi
I had some LiteDB, version 5, files i wanted to view, so i updated this repo to version 5. The details of my changes are in my commit messages. I made two commit because i was partially unsuccessful, and the second commit contains the files i was unsuccessful in updating. However - it is a start - and i thought perhaps you might want to create a new branch to pull these changes into but since there wasn't one i made the request to the master branch?

- LiteFileInfo now generic
- JsonSerializer parameters have been limited
- AsString method no longer works on ObjectId
- LiteDatabase now missing Engine property and Shrink method
- LiteFileInfo missing AsDocument property

References to version 4 converted to 5 via new Config property, 'Version'
…commented out)

- LiteException.DATABASE_WRONG_PASSWORD no longer exists
- LiteDatabase no longer takes logger in its constructor.
- DatabaseReference no longer has method RunCommand
@dtaylor-530 dtaylor-530 marked this pull request as draft May 17, 2020 10:41
@julianpaulozzi
Copy link
Owner

Hi, cool looks like a good start.
Yes, the ideal is create a new branch, I will see this as soon as possible.

I had pretensions to keep the single exe functional for versions 4 and 5, this proved possible but very complicated.
As I have limited time at the moment, the best option may be to proceed only with the version for LiteDB 5, more abstraction and assemblies for specific versions.

@dtaylor-530
Copy link
Author

Hi, yeah i saw there were some other people in the issue's sectoin requesting an update for version 5, so i figured a incomplete solution might be worthwhile. Especially if its on a separate branch.
On Gitter I asked a question about updating

LiteDatabase.Engine.Run(command);

I think it's this issue and the one concerning passwords that are only ones causing missing features.
Also great project.

@dtaylor-530 dtaylor-530 marked this pull request as ready for review May 28, 2020 15:52
@azhe403
Copy link

azhe403 commented Nov 16, 2020

Up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants